Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-location-alpha: support L2 Route Calculator Construct #30681

Closed
1 of 2 tasks
mazyu36 opened this issue Jun 26, 2024 · 3 comments · Fixed by #30682 · 4 remaining pull requests
Closed
1 of 2 tasks

aws-location-alpha: support L2 Route Calculator Construct #30681

mazyu36 opened this issue Jun 26, 2024 · 3 comments · Fixed by #30682 · 4 remaining pull requests
Labels
@aws-cdk/aws-location-alpha Related to the @aws-cdk/aws-location-alpha package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Jun 26, 2024 •
edited
Loading

Describe the feature

In aws-location-alpha, route calculator has not been supported yet.

Adding the RouteCalculator class to the alpha module enables easier usage.

Use Case

To use route calculator.

Proposed Solution

Add RouteCalculator class.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.147.0

Environment details (OS name and version, etc.)

all
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 26, 2024
This was referenced Jun 26, 2024
Merged
Open
@khushail khushail added effort/small Small work item – less than a day of effort p3 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 26, 2024
@khushail khushail removed their assignment Jun 26, 2024
@khushail
Copy link
Contributor

khushail commented Jun 26, 2024 •
edited by ashishdhingra
Loading

thanks for requesting this feature @mazyu36.

@ashishdhingra ashishdhingra changed the title (aws-location-alpha): support L2 Route Calculator Construct aws-location-alpha: support L2 Route Calculator Construct Jun 26, 2024
@ashishdhingra ashishdhingra added the @aws-cdk/aws-location-alpha Related to the @aws-cdk/aws-location-alpha package label Jun 26, 2024
This was referenced Jul 1, 2024
Closed
Closed
Closed
@mergify mergify bot closed this as completed in #30682 Aug 30, 2024
@mergify mergify bot closed this as completed in 574d383 Aug 30, 2024
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
xazhao pushed a commit to xazhao/aws-cdk that referenced this issue Sep 12, 2024
@mazyu36 @xazhao
feat(location): support RouteCalculator (aws#30682)
399bfb1 
### Issue # (if applicable)

Closes aws#30681 .

### Reason for this change
In [aws-location-alpha](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-location-alpha-readme.html), [route calculator](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_location.CfnRouteCalculator.html) has not been supported yet.



### Description of changes
Add `RouteCalculator` class.



### Description of how you validated changes
Add unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-location-alpha Related to the @aws-cdk/aws-location-alpha package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3
Projects
None yet
Milestone
No milestone
3 participants
@mazyu36 @ashishdhingra @khushail