fix(iam): User.fromUserName not implementing IUSER functions #10527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
requested changes
Sep 30, 2020
| public addToGroup(_group: IGroup): void { | ||
| throw new Error('Cannot add imported User to Group'); | ||
| public addToGroup(group: IGroup): void { | ||
| this.groups.push(group.groupName); |
There was a problem hiding this comment.
I don't think this is sufficient. If the User is being created you can add it to a group in this way, but fairly sure that's not how you do it if the User already exists.
| } | ||
|
|
||
| public attachInlinePolicy(_policy: Policy): void { | ||
| throw new Error('Cannot add inline policy to imported User'); | ||
| public attachInlinePolicy(policy: Policy): void { |
There was a problem hiding this comment.
Will this actually add an inline policy to an already-existing User object? I don't think so.
| public addManagedPolicy(_policy: IManagedPolicy): void { | ||
| throw new Error('Cannot add managed policy to imported User'); | ||
| public addManagedPolicy(policy: IManagedPolicy): void { | ||
| if (this.managedPolicies.find(mp => mp === policy)) { return; } |
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2020
It was not possible to attach policies to imported `User` objects. This can be made to work though, as the underlying CloudFormation resource allows doing so. Make this work in the class library. Fixes #10913, closes #11046, closes #10527. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User.fromUserName not implementing IUSER functions
closes #5797
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license