Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iam): Error for addToPolicy and addToPrincipalPolicy in User.fromUserName corrected... #11046
fix(iam): Error for addToPolicy and addToPrincipalPolicy in User.fromUserName corrected... #11046
Changes from all commits
d59c84d
bf1f3ce
b313489
051aba0
140d4ba
d824bc3
4b66e95
7191ade
5db1d0b
08db2db
26eaa56
c078d5a
bd48d76
5a35324
0cf2bfe
5364cf8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message is the wrong way around.
Cannot add policy to imported User principal
makes more sense to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sort of fine having this throw an error, but as discussed in #10913 this could just be made to work.
If you add an
AWS::IAM::Policy
and you give it the rightUserName
, it becomes possible to add an identity policy to an existing identity, as far as I can tell.Why don't we just do that?
Maybe the correct fix is to figure out where the exception that was mentioned in #10913 is thrown, and make sure that error isn't thrown anymore. Because the content of
addToPrincipalPolicy
mostly seems correct, except it probably throws whenattachToUser
is called... (?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message will be common with
addToPolicy
function so maybe we can throw this messageCannot add policy to imported User
.If we don't want to throw an error then there are several problems here if we try to correct the functionality because its not like other functions are working. The
attachToUser
will call toattachInlinePolicy
which will throw an error, I can try to fix that function...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, should I check for the correct functionality or throw an error instead??