Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codebuild): update default build image to STANDARD_4_0 #12002

Closed

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Dec 10, 2020

By default, CodeBuild projects were defaulting to aws/codebuild/standard:1.0, which is quite old. According to these docs:

The latest version of each image is cached. If you specify a more specific version, then CodeBuild provisions that version instead of the cached version. This can result in longer build times.

Before I specified a newer build image, my CodeBuild project was taking 4+ minutes to provision and I was confused about why it was so slow. When I dug deeper and found the docs linked above, provisioning took less than 30 seconds.

Therefore, to provide users the best out-of-the-box experience, I believe the default should be the newer, cached image. This PR updates that default.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 10, 2020

@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Dec 10, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5b0e68e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@blimmer
Copy link
Contributor Author

blimmer commented Dec 10, 2020

I'll fix these tests up in a bit.

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not before v2 😉

@blimmer
Copy link
Contributor Author

blimmer commented Dec 10, 2020

Hey @skinny85 - I don't actually know about v2 - is there a code freeze or something?

@skinny85
Copy link
Contributor

No, this would just be a breaking change in version 1.x of CDK. See #11960 .

@blimmer
Copy link
Contributor Author

blimmer commented Dec 10, 2020

Ah, OK, I understand now. I didn't see that other issue. Are breaking changes only acceptable for certain (experimental) packages?

@skinny85
Copy link
Contributor

Are breaking changes only acceptable for certain (experimental) packages?

Yep. When we declare a give package "Stable", like CodeBuild is now, we no longer allow breaking changes to it in minor releases (like 1.76.0 to 1.77.0).

Any breaking changes to these have to be reserved for a major version release (like 1.77.0 to 2.0.0).

@skinny85
Copy link
Contributor

Closing in favor of #14472.

@skinny85 skinny85 closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants