-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(codebuild): update default build image to STANDARD_4_0 #12002
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
I'll fix these tests up in a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not before v2 😉
Hey @skinny85 - I don't actually know about v2 - is there a code freeze or something? |
No, this would just be a breaking change in version 1.x of CDK. See #11960 . |
Ah, OK, I understand now. I didn't see that other issue. Are breaking changes only acceptable for certain (experimental) packages? |
Yep. When we declare a give package "Stable", like CodeBuild is now, we no longer allow breaking changes to it in minor releases (like Any breaking changes to these have to be reserved for a major version release (like |
Closing in favor of #14472. |
By default, CodeBuild projects were defaulting to
aws/codebuild/standard:1.0
, which is quite old. According to these docs:Before I specified a newer build image, my CodeBuild project was taking 4+ minutes to provision and I was confused about why it was so slow. When I dug deeper and found the docs linked above, provisioning took less than 30 seconds.
Therefore, to provide users the best out-of-the-box experience, I believe the default should be the newer, cached image. This PR updates that default.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license