feat(glue): SecurityConfiguration construct #12450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I am working to add integration tests. This is making me realize some changes are needed to the construct which I'll refactor in addition to the integ tests |
- S3Encryptions in CloudFormation accepts an array of max length 1, otherwise CloudFormation deployment fails with "S3 EncryptionConfiguration list cannot be greater than one" - Based on that, change SecurityConfigurationProps to expose a single S3Encryption configuration instead of an array - Add checks on props to ensure and throw exception otherwise - At least one of the encryption configurations (s3, cloudwatch, jobs bookmarks) is provided otherwise CloudFormation deployment fails - kmsKey cannot be empty if the encryption mode requires a kms key
enum constants are chosen to be consistent with similar enum in table.ts
This was referenced Jan 14, 2021
iliapolo
changed the title
iliapolo
previously requested changes
Feb 14, 2021
iliapolo
added
the
response-requested
- remove DISABLED from enums - auto-create and expose a kms key if one is not provided - fix README.md
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
|
@humanzz When you're ready for another round - just re-request the review, cool? |
ready and re-requested the review :) |
iliapolo
reviewed
Feb 15, 2021
iliapolo
reviewed
Feb 15, 2021
iliapolo
changed the title
iliapolo
previously approved these changes
Feb 15, 2021
iliapolo
removed
the
response-requested
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
iliapolo
approved these changes
Feb 15, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
Closes aws#12449 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12449
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license