Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 1.134.0 #17644

Merged
merged 21 commits into from
Nov 23, 2021
Merged

chore(release): 1.134.0 #17644

merged 21 commits into from
Nov 23, 2021

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Nov 23, 2021

See CHANGELOG

moelasmar and others added 20 commits November 19, 2021 20:42
Following up on issue #14593

The integration with SAM tool requires to have some more info about the Assets. SAM needs to know if the Asset was already bundled or not, and what is the original asset path before staging.

This change is to add the following assets metadata:
 - aws:asset:is-bundled 
 - aws:asset:original-path

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for Apache Kafka version 2.6.2 in Amazon MSK.

Announcement: https://aws.amazon.com/about-aws/whats-new/2021/04/amazon-msk-adds-support-for-apache-kafka-version-2-6-2/

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…e types (#16911)

Currently, the following valid cluster configurations are not possible to be created with CDK.

```ts
new es.Domain(stack, 'Domain1', {
    version: es.EngineVersion.OPENSEARCH_1_0,
    ebs: { enabled: false },
    capacity: {
        masterNodes: 3,
        masterNodeInstanceType: 'c5.2xlarge.search',
        dataNodeInstanceType: 'i3.2xlarge.search'
    }
});


new es.Domain(stack, 'Domain2', {
    version: es.EngineVersion.OPENSEARCH_1_0,
    ebs: { enabled: false, },
    capacity: {
        masterNodes: 3,
        masterNodeInstanceType: 'c6g.large.search',
        dataNodeInstanceType: 'r6gd.large.search'
    }
});
```
Throws error:
`EBS volumes are required when using instance types other than r3, i3 or r6gd.`

Here, EBS validation is being checked on master nodes instead of just the data nodes -  which causes the above failure.

This PR applies fix on both `elasticsearch` and `opensearchservice` modules

Fixes #11898 

----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fix(aws-ecs): add precheck name of capacity provider when specify it.
chore(aws-ecs): update capacityProviderName Description


close #17321
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…7614)

When identifying missing examples for a module, we need to also iterate over all submodules and account for classes and structs there.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…t migration (#17518)

Updating the L2 construct for `AWS::ApiGatewayV2::DomainName` resource to add support for DomainNameConfigurations.
DomainNameConfigurations is a list of configurations for an API's domain name (CFN equivalent - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apigatewayv2-domainname-domainnameconfiguration.html) which includes endpoint type, security policy, ownership certificate.

Changes include:
- Code update to support the properties mentioned above
- Unit test changes for existing tests to account for the updated `domainNameConfigurations` Lazy evaluation. 
- New unit tests for mutual tls with ownership certificate, and domain name migration that were not present before.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Co-authored-by: AWS CDK Team <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
fixes: #17605 
```bash
Checking if node is installed... Ok
Checking node version... Ok
Checking if yarn is installed... Ok
Checking yarn version... Ok
Checking if docker is installed... Ok
Checking if docker is running... Ok
Checking if dotnet is installed... Ok
Checking dotnet version... Ok
Checking if python3 is installed... Ok
Checking python3 version... Ok
```

and everything seems to build fine

Think fixes to test files are unnecessary, and don't know what to document for this...

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Create a fixture and immediately switch on strict mode.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for deploying the [AWS ALB Controller](https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.3/) onto the cluster. 

Resolves #8836

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Some examples don't compile because we can emit some imports
twice.

This is because we expect imports to be sorted, and only deduplicate
pairwise, but we forgot to include submodule in the sort key.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes: #17572
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…17573) (#17635)

This is an automatic backport of pull request #17573 done by [Mergify](https://mergify.com).
Cherry-pick of 66e37cc has failed:
```
On branch mergify/bp/master/pr-17573
Your branch is up to date with 'origin/master'.

You are currently cherry-picking commit 66e37cc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   packages/@aws-cdk/cfnspec/test/libary-creation.test.ts
	modified:   packages/aws-cdk-lib/.gitignore
	modified:   packages/aws-cdk-lib/package.json
	modified:   packages/aws-cdk-lib/scripts/verify-imports-resolve-same.ts
	deleted:    packages/aws-cdk-lib/scripts/verify-readme-import-rewrites.ts
	modified:   packages/aws-cdk-migration/bin/rewrite-imports-v2.ts
	modified:   packages/aws-cdk-migration/lib/rewrite.ts
	modified:   packages/aws-cdk-migration/test/rewrite.test.ts
	modified:   packages/monocdk/.gitignore
	modified:   tools/@aws-cdk/cdk-build-tools/bin/cdk-build.ts
	modified:   tools/@aws-cdk/individual-pkg-gen/transform-packages.ts
	modified:   tools/@aws-cdk/ubergen/bin/ubergen.ts
	modified:   tools/@aws-cdk/ubergen/package.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   packages/@aws-cdk/cfnspec/lib/library-creation.ts

```


To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…17634)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation added the pr/no-squash This PR should be merged instead of squash-merging it label Nov 23, 2021
@gitpod-io
Copy link

gitpod-io bot commented Nov 23, 2021

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 23, 2021

@Mergifyio merge b45be32

@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2021

Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Nov 23, 2021
@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ce6137f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 23, 2021

This PR is waiting for @addihorowitz to change package descriptions

@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Nov 23, 2021
@mergify mergify bot merged commit dd5e12d into release Nov 23, 2021
@mergify mergify bot deleted the bump/1.134.0 branch November 23, 2021 13:46
@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2021

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants