Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't collect runtime information when versionReporting is disabled #1890

Merged
merged 2 commits into from
Feb 28, 2019
Merged

fix: Don't collect runtime information when versionReporting is disabled #1890

merged 2 commits into from
Feb 28, 2019

Conversation

stephankaag
Copy link
Contributor

@stephankaag stephankaag commented Feb 26, 2019 •
edited
Loading

When versionReporting is turned off, don't collect runtime information.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@stephankaag stephankaag requested a review from a team as a code owner February 26, 2019 10:57
@eladb
Copy link
Contributor

eladb commented Feb 27, 2019

@RomainMuller

RomainMuller
RomainMuller approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@RomainMuller RomainMuller merged commit f827a88 into aws:master Feb 28, 2019
@RomainMuller RomainMuller changed the title Don't collect runtime information when versionReporting is disabled fix: Don't collect runtime information when versionReporting is disabled Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephankaag @eladb @RomainMuller