Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-apprunner): fix integration tests #19660

Merged
merged 2 commits into from
Apr 1, 2022
Merged

chore(aws-apprunner): fix integration tests #19660

merged 2 commits into from
Apr 1, 2022

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented Mar 31, 2022

splitting up the integration tests into separate tests so that we can
separate the ones that can be run and those that can't. The github test
requires a connection to github so it can't be run in automation.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use cdk-integ to deploy the infrastructure and generate the snapshot (i.e. cdk-integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

splitting up the integration tests into separate tests so that we can
separate the ones that can be run and those that can't. The github test
requires a connection to github so it can't be run in automation.
@gitpod-io
Copy link

gitpod-io bot commented Mar 31, 2022

@github-actions github-actions bot added p2 @aws-cdk/aws-apprunner Related to the apprunner package labels Mar 31, 2022
@corymhall corymhall requested a review from a team March 31, 2022 19:12
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 31, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 1, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4071d9b into aws:master Apr 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 1, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 97978da
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
splitting up the integration tests into separate tests so that we can
separate the ones that can be run and those that can't. The github test
requires a connection to github so it can't be run in automation.


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apprunner Related to the apprunner package contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants