chore(aws-ec2): fix broken integration tests #19690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple of fixes: - `integ.instance-init`: Create a new VPC instead of performing a lookup in order to make the stack env agnostic - `integ.vpc-endpoint-service`: Moved this test to the elasticloadbalancingv2 package since for the test to actually do anything it needs to create NLBs. - `integ.vpc-endpoint-service-cn`: Removed this test since it is the same as the above test except for creating it in china - `integ.vpc-flow-logs`: Added `autoDeleteObjects` so that the stack can be deleted. Also added the bucket policy to the bucket to avoid some race conditions when the stack tries to delete the bucket while AWS is attempting to add this policy to the bucket. - `integ.vpn-pre-shared-key-token`: The purpose of this test seemed to be validating that a token can be used so I changed this to just use `Lazy`. Also, that property does not support SSM Secure references.
|
|
rix0rrr
approved these changes
Apr 1, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
Couple of fixes: - `integ.instance-init`: Create a new VPC instead of performing a lookup in order to make the stack env agnostic - `integ.vpc-endpoint-service`: Moved this test to the elasticloadbalancingv2 package since for the test to actually do anything it needs to create NLBs. - `integ.vpc-endpoint-service-cn`: Removed this test since it is the same as the above test except for creating it in china - `integ.vpc-flow-logs`: Added `autoDeleteObjects` so that the stack can be deleted. Also added the bucket policy to the bucket to avoid some race conditions when the stack tries to delete the bucket while AWS is attempting to add this policy to the bucket. - `integ.vpn-pre-shared-key-token`: The purpose of this test seemed to be validating that a token can be used so I changed this to just use `Lazy`. Also, that property does not support SSM Secure references. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of fixes:
integ.instance-init: Create a new VPC instead of performing a lookupin order to make the stack env agnostic
integ.vpc-endpoint-service: Moved this test to theelasticloadbalancingv2 package since for the test to actually do
anything it needs to create NLBs.
integ.vpc-endpoint-service-cn: Removed this test since it is thesame as the above test except for creating it in china
integ.vpc-flow-logs: AddedautoDeleteObjectsso that the stack canbe deleted. Also added the bucket policy to the bucket to avoid some
race conditions when the stack tries to delete the bucket while AWS is
attempting to add this policy to the bucket.
integ.vpn-pre-shared-key-token: The purpose of this test seemed tobe validating that a token can be used so I changed this to just use
Lazy. Also, that property does not support SSM Secure references.All Submissions:
Adding new Unconventional Dependencies:
New Features
cdk-integto deploy the infrastructure and generate the snapshot (i.e.cdk-integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license