chore(cli): revert concurrency PR #20230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 45a2d63.
|
|
4 tasks
kaizencc
approved these changes
May 5, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
4 tasks
wphilipw
pushed a commit
to wphilipw/aws-cdk
that referenced
this pull request
May 23, 2022
Reverts aws#19378 It breaks 4 integ tests: ``` ● security related changes without a CLI are expected to fail ... (node:7140) UnhandledPromiseRejectionWarning: Error: \"--require-approval\" is enabled and stack includes security-sensitive updates, but terminal (TTY) is not attached so we are unable to get a confirmation from the user ● update to stack in ROLLBACK_COMPLETE state will delete stack and create a new one expect(received).rejects.toThrow() Received promise resolved instead of rejected Resolved to value: "" at expect (../node_modules/expect/build/index.js:128:15) at expect (cli.integtest.ts:267:9) at block (../helpers/cdk.ts:131:13) at runMicrotasks (<anonymous>) at ResourcePool.using (../helpers/resource-pool.ts:44:14) at ../helpers/test-helpers.ts:36:14 ● stack in UPDATE_ROLLBACK_COMPLETE state can be updated expect(received).rejects.toThrow() Received promise resolved instead of rejected Resolved to value: "" at expect (../node_modules/expect/build/index.js:128:15) at expect (cli.integtest.ts:320:9) at runMicrotasks (<anonymous>) at ../helpers/cdk.ts:131:7 at ResourcePool.using (../helpers/resource-pool.ts:44:14) at ../helpers/test-helpers.ts:36:14 ● failed deploy does not hang ... (node:8336) UnhandledPromiseRejectionWarning: Error: The stack named cdktest-0m9jeq4rpbp-failed failed creation, it may need to be manually deleted from the AWS console: ROLLBACK_COMPLETE: Property PolicyDocument cannot be empty. ``` Something around the handling of errors in the new async deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19378
It breaks 4 integ tests:
Something around the handling of errors in the new async deployment.