Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-glue): add glue table serde parameters #22326

Closed
wants to merge 1 commit into from
Closed

feat(aws-glue): add glue table serde parameters #22326

wants to merge 1 commit into from

Conversation

JeromeGuyon
Copy link
Contributor

@JeromeGuyon JeromeGuyon commented Oct 2, 2022

Supports to glue table serde parameters :

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-table-serdeinfo.html#cfn-glue-table-serdeinfo-parameters

fixes #14159


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 2, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team October 2, 2022 21:42
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Oct 2, 2022
@Naumel Naumel added the @aws-cdk/aws-glue Related to AWS Glue label Oct 3, 2022
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeromeGuyon thanks for the PR! Just a couple of minor comments.

packages/@aws-cdk/aws-glue/lib/data-format.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue/lib/data-format.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed corymhall’s stale review October 3, 2022 17:19

Pull request has been modified.

@JeromeGuyon JeromeGuyon marked this pull request as draft October 7, 2022 08:45
@JeromeGuyon JeromeGuyon marked this pull request as ready for review October 9, 2022 10:20
@TheRealAmazonKendra TheRealAmazonKendra self-assigned this Oct 19, 2022
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5f1a9a0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-glue Related to AWS Glue beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(glue): Missing parameter *parameters* from class Table (construct)
5 participants