Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch convenience package cdk to stable #25433

Merged
merged 3 commits into from
May 26, 2023
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 4, 2023

This was intended to be able to do npx cdk out of the blue, but that won't work as long as the package has a prerelease tag.

The rest of the changes are forced upon me by pkglint.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This was intended to be able to do `npx cdk` out of the blue, but that
won't work as long as the package has a prerelease tag.

The rest of the changes are forced upon me by `pkglint`.
@rix0rrr rix0rrr requested a review from a team May 4, 2023 08:43
@rix0rrr rix0rrr self-assigned this May 4, 2023
@gitpod-io
Copy link

gitpod-io bot commented May 4, 2023

@github-actions github-actions bot added the p2 label May 4, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 4, 2023 08:43
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 4, 2023
@Naumel
Copy link
Contributor

Naumel commented May 10, 2023

Log summary:

   Failed tasks:
   - cdk:build

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 26, 2023
@mergify
Copy link
Contributor

mergify bot commented May 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c147388
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 784cd0e into main May 26, 2023
@mergify mergify bot deleted the huijbers/stable-conv branch May 26, 2023 10:08
@mergify
Copy link
Contributor

mergify bot commented May 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants