Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events-targets): support enableExecuteCommand in EcsTask construct #25639

Merged
merged 5 commits into from
Jun 4, 2023

Conversation

ymhiroki
Copy link
Contributor

@ymhiroki ymhiroki commented May 18, 2023

Users can run commands in or get a shell to a container running on an Amazon EC2 instance or on AWS Fargate with Amazon ECS Exec.

FargateService and Ec2Service in aws-ecs supports the flag to enable Amazon ECS Exec, enableExecuteCommand.
EcsTask in aws-events-targets also supports enableExecuteCommand in CloudFormation, but AWS CDK doesn't.
This feature supports enableExecuteCommand flag also for EcsTask.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 18, 2023

@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels May 18, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 18, 2023 07:38
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@ymhiroki ymhiroki changed the title feat(events-targets) support enableExecuteCommand in EcsTask construct feat(events-targets): support enableExecuteCommand in EcsTask construct May 18, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 18, 2023 07:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 18, 2023
otaviomacedo
otaviomacedo previously approved these changes Jun 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ymhiroki
Copy link
Contributor Author

ymhiroki commented Jun 2, 2023

@otaviomacedo the GitHub workflow to merge this PR seems to be failed: link.
Do you have any ideas about the below error message?

refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-issues.yml without workflows permission
err-code: 18BA7

@mergify mergify bot dismissed otaviomacedo’s stale review June 4, 2023 14:47

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: adac3c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7f3152a into aws:main Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants