feat(stepfunctions): add getters for context object fields #25646
Conversation
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
…text object fields Signed-off-by: Francis <[email protected]>
… test to generate new snapshots Signed-off-by: Francis <[email protected]>
|
|
github-actions
bot
added
effort/small
aws-cdk-automation
added
the
pr/needs-community-review
| @@ -49,6 +49,18 @@ const checkJobState = new LambdaInvoke(stack, 'Check the job state', { | |||
| resultSelector: { | |||
| status: sfn.JsonPath.stringAt('$.Payload.status'), | |||
| }, | |||
| payload: sfn.TaskInput.fromObject({ | |||
There was a problem hiding this comment.
Can you add an assertion here to assert that the state machine execution
succeeded? The reason that the assertion is needed is because this test
currently only tests that the state machine is able to be deployed, but there is
not any validation that the state machine is actually valid and will execute.
You can find an example here
https://github.com/corymhall/aws-cdk/blob/53d24f1a1357410746052bbf25b5b89b985f7b80/packages/@aws-cdk-testing/framework-integ/test/aws-stepfunctions-tasks/test/aws-sdk/integ.call-aws-service-sfn.ts#L38-L49
You can probably also have the lambda function validate that all those fields
are set.
There was a problem hiding this comment.
Thanks for catching this and providing an example. I used the example you provided to include an assertion. I also added code that passes a payload to the lambda function with the newly added fields set. The lambda then checks that each of the expected fields are set and returns SUCCEEDED only if all fields are set (not undefined) and the statusCode is 200.
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
…tests, and updated snapshots Signed-off-by: Francis <[email protected]>
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
pr/needs-cli-test-run
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
| const res = integ.assertions.awsApiCall('StepFunctions', 'startExecution', { | ||
| stateMachineArn: sm.stateMachineArn, | ||
| }); | ||
| const executionArn = res.getAttString('executionArn'); |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR adds additional getters to allow easy access to context object fields. We currently have getters allowing easy access to the entire context object and the context object task token field. This adds getters for the following additional context object fields:
Closes #25415
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license