Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synthetics): syn-nodejs-puppeteer-4.0 runtime #25745

Closed
wants to merge 1 commit into from

Conversation

Tsenko
Copy link

@Tsenko Tsenko commented May 25, 2023

This pull request introduces the new syn-nodejs-puppeteer-4.0 runtime to the AWS-CDK.

The intention behind this update is to accommodate the latest version of Node.js and Puppeteer in the AWS Cloud Development Kit (AWS-CDK), which has been already integrated as a feature according to the official AWS documentation - AWS CloudWatch Synthetics Canaries with Node.js and Puppeteer

During my recent work, I received a recommendation in the AWS console to update the runtime version of my canary. However, upon trying to implement this through code, I found that it wasn't available as an option in the AWS-CDK. This pull request aims to address this discrepancy and provide users with the capability to use the syn-nodejs-puppeteer-4.0 runtime version.

I appreciate your review and consideration of this update.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Adds the new syn-nodejs-puppeteer-4.0 runtime.
@gitpod-io
Copy link

gitpod-io bot commented May 25, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 25, 2023 20:23
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels May 25, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Tsenko Tsenko changed the title Update runtime.ts feat(runtime): Add syn-nodejs-puppeteer-4.0 to AWS-CDK May 25, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e613999
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kaizencc kaizencc changed the title feat(runtime): Add syn-nodejs-puppeteer-4.0 to AWS-CDK feat(synthetics): syn-nodejs-puppeteer-4.0 runtime May 30, 2023
@kaizencc kaizencc added the pr-linter/exempt-readme The PR linter will not require README changes label May 30, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@kaizencc
Copy link
Contributor

Actually this is a duplicate of #25553

@kaizencc kaizencc closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants