Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cdk-release): alpha package changes aren't written to alpha CHANGELOG #25836

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 2, 2023

The reason is that the packages that have the changes in them are now called @aws-cdk/aws-XXX-alpha, but changes are usually stated as feat(XXX): ....

The code generating name variants to catch the possible values of XXX was not taking the -alhpa suffix into account. Now is.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…NGELOG

The reason is that the packages that have the changes in them are now
called `@aws-cdk/aws-XXX-alpha`, but changes are usually stated as
`feat(XXX): ...`.

The code generating name variants to catch the possible values of `XXX`
was not taking the `-alhpa` suffix into account. Now is.
@rix0rrr rix0rrr requested a review from a team June 2, 2023 13:43
@gitpod-io
Copy link

gitpod-io bot commented Jun 2, 2023

@github-actions github-actions bot added the p2 label Jun 2, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 2, 2023 13:43
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ca0cdda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2bcd7f2 into main Jun 2, 2023
@mergify mergify bot deleted the huijbers/alpha-changelog branch June 2, 2023 14:36
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants