fix(cli): ENOENT during asset publishing #25869
Conversation
There was still a TOCTOU error in the file asset publishing, which could
lead to `ENOENT: no such file or directory` when assets were being published
in parallel.
The whole `if (fileExists) { delete; }` logic was actually not
necessary, as `fs.rename` will atomically overwrite existing files
already, so we can just call it directly.
Closes #25293.
|
|
rix0rrr
added
the
pr-linter/exempt-integ-test
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
rix0rrr
added
the
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
github-actions
bot
added
bug
There was still a TOCTOU error in the file asset publishing, which could lead to
ENOENT: no such file or directorywhen assets were being published in parallel.The whole
if (fileExists) { delete; }logic was actually not necessary, asfs.renamewill atomically overwrite existing files already, so we can just call it directly.Closes #25293.
Closes #25380
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license