Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): imported clusters can't deploy manifests #25908

Merged
merged 10 commits into from
Jun 12, 2023

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Jun 8, 2023

The imported eks clusters are having invalid service token and can't deploy new k8s manifests or helm charts. This PR fixes that issue.

  • Update README and doc string. functionArn should be the custom resource provider's service token rather than the kubectl provider lambda arn. No breaking change in this PR.
  • Add a new integration test to ensure the imported cluster can always create manifests and helm charts.

Closes #25835


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 8, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 8, 2023 19:12
@github-actions github-actions bot added bug This issue is a bug. p1 labels Jun 8, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 8, 2023
@pahud pahud marked this pull request as ready for review June 8, 2023 19:15
@pahud pahud changed the title fix(eks): imported clusters can't deploy fix(eks): imported clusters can't deploy manifests Jun 8, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 9, 2023 15:45

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 9, 2023
@pahud
Copy link
Contributor Author

pahud commented Jun 9, 2023

Hi @otaviomacedo please take a look again. Thanks.

@pahud pahud requested a review from otaviomacedo June 9, 2023 17:44
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5a862f6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 23a84d3 into aws:main Jun 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@dancmeyers
Copy link

I'm afraid this doesn't fix the reported error. See #25938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eks: After upgrading to 2.80, imported cluster resources fail to deploy
4 participants