Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfnspec): cloudformation spec v127.0.0 #26009

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Jun 16, 2023

No description provided.

@aws-cdk-automation aws-cdk-automation added auto-approve pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jun 16, 2023
@gitpod-io
Copy link

gitpod-io bot commented Jun 16, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 16, 2023 09:06
@github-actions github-actions bot added the p2 label Jun 16, 2023
github-actions[bot]
github-actions bot previously approved these changes Jun 16, 2023
The CFN property type change from `Timestamp` -> `String` in v126.0.0.
We adjusted the L2 code accordingly.
The CFN property type change was than reverted in v127.0.0.
So we have to revert our L2 fix as well.
@mergify mergify bot dismissed github-actions[bot]’s stale review June 20, 2023 09:39

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ffbe132
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4e57a8c into main Jun 20, 2023
@mergify mergify bot deleted the bump-cfnspec-main/v127.0.0 branch June 20, 2023 11:06
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-approve p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants