Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): remove support for applets #2691

Merged
merged 1 commit into from
May 30, 2019
Merged

fix(cli): remove support for applets #2691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions packages/aws-cdk/lib/api/cxapp/exec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,6 @@ function appToArray(app: any) {

type CommandGenerator = (file: string) => string[];

/**
* Direct execution of a YAML file, assume that we're deploying an Applet
*/
function executeApplet(appletFile: string): string[] {
const appletBinary = path.resolve(require.resolve('@aws-cdk/applet-js'));
return [process.execPath, appletBinary, appletFile];
}

/**
* Execute the given file with the same 'node' process as is running the current process
*/
Expand All @@ -166,8 +158,6 @@ function executeNode(scriptFile: string): string[] {
* Mapping of extensions to command-line generators
*/
const EXTENSION_MAP = new Map<string, CommandGenerator>([
['.yml', executeApplet],
['.yaml', executeApplet],
['.js', executeNode],
]);

Expand Down
1 change: 0 additions & 1 deletion packages/aws-cdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"sinon": "^7.3.1"
},
"dependencies": {
"@aws-cdk/applet-js": "^0.33.0",
"@aws-cdk/cloudformation-diff": "^0.33.0",
"@aws-cdk/cx-api": "^0.33.0",
"@aws-cdk/region-info": "^0.33.0",
Expand Down