Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): asset not uploaded with different synthesizer configs #26910

Merged
merged 8 commits into from
Aug 29, 2023

Commits on Aug 28, 2023

  1. fix(cli): asset not uploaded with different synthesizer configs

    If the same asset is used in 2 stacks that use different synthesizer
    configurations for publishing (for example, by using a different prefix)
    the asset will only be uploaded once instead of twice.
    
    We used to make the assumption that it was okay to use the destination
    ID as token of uniqueness. This is true inside a single manifest, but
    does not hold when there is more than stack that each have a manifest:
    both may have the destination ID `current_account:current_region`, but
    have different parameters for each destination.
    
    Instead, we calculate a content hash over the destination definition
    itself. That way, if the definitions are different we will create
    different nodes for each of them.
    
    Fixes #25927.
    rix0rrr committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    aa8d9ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e811dda View commit details
    Browse the repository at this point in the history
  3. Undo rename

    rix0rrr committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    704393e View commit details
    Browse the repository at this point in the history
  4. It's not a Merkle hash

    rix0rrr committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0673fb9 View commit details
    Browse the repository at this point in the history
  5. Fix problem in the hash

    rix0rrr committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e00882c View commit details
    Browse the repository at this point in the history
  6. Hashes

    rix0rrr committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e854ad2 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Make matching more reliable

    rix0rrr committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2f5856f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2dd856d View commit details
    Browse the repository at this point in the history