-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: align-version script drops caret from dependencies it rewrites #27376
Conversation
The `align-version` script is supposed to rewrite `0.0.0` -> `2.99.0`, and also to rewrite `^0.0.0` -> `^2.99.0`. It didn't do the latter, because of a variable shadowing mistake. That mistake happened to come out correctly often enough that we didn't notice it. Fix that bug. Also add a linting rule that says that all peerDependencies should have a `^` dependency on `aws-cdk-lib`.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Synthetics was stabilized in #27305 and the alpha module was removed. Due to a bug in `align-versions.sh`, the last published `@aws-cdk/aws-synthetics-alpha` module relied on a peer dependency of `[email protected]` instead of `aws-cdk-lib@^2.99.0` (with the caret). This makes `@aws-cdk/aws-synthetics-alpha incompatible with later versions of aws-cdk-lib, and is unintentional. #27376 fixes the bug in `align-versions.sh`, and this PR re-introduces `@aws-cdk/aws-synthetics-alpha` for one last version of CDK (v2.100.0) before we remove it again. This should have the effect of `@aws-cdk/[email protected]` being the last version of the alpha module, but still compatible with later versions of `aws-cdk-lib` by having the peer dependency `aws-cdk-lib@^2.100.0`. We still want users to migrate to the stable synthetics module at `aws-cdk-lib/aws-synthetics`, but we don't want to outright break existing users of the experimental module either. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The
align-version
script is supposed to rewrite0.0.0
->2.99.0
, and also to rewrite^0.0.0
->^2.99.0
. It didn't do the latter, because of a variable shadowing mistake. That mistake happened to come out correctly often enough that we didn't notice it.Fix that bug.
Also add a linting rule that says that all peerDependencies should have a
^
dependency onaws-cdk-lib
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license