Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@aws-cdk/aws-events-targets): event-rules cannot have targets with the same construct id #2744

Merged
merged 23 commits into from
Jun 17, 2019
Merged

fix(@aws-cdk/aws-events-targets): event-rules cannot have targets with the same construct id #2744

merged 23 commits into from
Jun 17, 2019

Commits on Jun 4, 2019

  1. fix(@aws-cdk/aws-events-targets): event-rules cannot have targets wit… 

    …h the same construct id.
    @made2591
    made2591 committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    ce33b40 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2019

  1. fix uniqueId dimension to 64 chars

    @made2591
    made2591 committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    58a6cbc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/aws-events-node-unique-id

    @made2591
    made2591 committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    b824cd4 View commit details
    Browse the repository at this point in the history

  3. fix integ.instance.lit.expected.json (got from Travis): local build d… 

    …oes not work
    @made2591
    made2591 committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    5fd1465 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2019

  1. Merge remote-tracking branch 'upstream/master' into fix/aws-events-no… 

    …de-unique-id
    @made2591
    made2591 authored and Madeddu, Matteo committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    f4783eb View commit details
    Browse the repository at this point in the history

  2. move uniqueId cut inside aws-events/lib/rule.ts. change in uniqueId i… 

    …n events target
    @made2591
    made2591 committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    c378546 View commit details
    Browse the repository at this point in the history

  3. fix integration tests after uniqueId migration.

    @made2591
    made2591 committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    bdc8c3c View commit details
    Browse the repository at this point in the history

  4. change uniqueId for ecs-task target rule. fix integration tests

    @made2591
    made2591 committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    f099eb0 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master'

    @made2591
    Madeddu, Matteo authored and made2591 committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    be8c70a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fix/aws-events-node-unique-id

    @made2591
    Madeddu, Matteo authored and made2591 committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    02cf01b View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. fix integration test in aws-codepipeline-actions/test/

    @made2591
    made2591 committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    0f4a4c0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into fix/aws-events-no… 

    …de-unique-id
    @made2591
    made2591 committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    e4a8447 View commit details
    Browse the repository at this point in the history

  3. fix tests in packages/@aws-cdk/aws-ecs-patterns/test/

    @made2591
    made2591 committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    7dd818b View commit details
    Browse the repository at this point in the history

  4. fix test in packages/@aws-cdk/aws-codepipeline-actions/test/integ.lam… 

    …bda-deployed-through-codepipeline.lit.expected.json
    @made2591
    made2591 committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    532c02e View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. fix codepipeline actions tests. wip

    @made2591
    made2591 committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    c27e874 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into fix/aws-events-no… 

    …de-unique-id
    @made2591
    Madeddu, Matteo authored and made2591 committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    fbfe7d3 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into fix/aws-events-no… 

    …de-unique-id
    @made2591
    made2591 committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    3c104a7 View commit details
    Browse the repository at this point in the history

  4. fix integration tests accordingly

    @made2591
    made2591 committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    475301a View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. Fix import

    @rix0rrr
    rix0rrr committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    19953e7 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. Update some expectations

    @rix0rrr
    rix0rrr committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    f3e3aaa View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2019

  1. Merge remote-tracking branch 'upstream/master' into fix/aws-events-no… 

    …de-unique-id
    @made2591
    made2591 committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    0d4c101 View commit details
    Browse the repository at this point in the history

  2. Update expectations of lambda sns and sqs

    @made2591
    made2591 committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    d81c991 View commit details
    Browse the repository at this point in the history

  3. Update expectations in @aws-cdk/aws-codepipeline-actions/

    @made2591
    made2591 committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    981a7d7 View commit details
    Browse the repository at this point in the history