Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appconfig): support for CfnMonitorsProperty in environments #27680

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

chenjane-dev
Copy link
Contributor

@chenjane-dev chenjane-dev commented Oct 25, 2023

Adding support to associate our L1 monitors constructs (CfnMonitorsProperty) to a L2 environment construct.

BREAKING CHANGE
To define monitors under an environment, you now need to call a static method on Monitor.
Example:

new Environment(this, 'MyEnv', {
   ....
   monitors: [
      Monitor.fromCloudWatchAlarm(...),
      Monitor.fromCfnMonitorProperty(...),
   ],
});

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 25, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 25, 2023 18:20
@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Oct 25, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@chenjane-dev chenjane-dev changed the title Cfn monitors support feat(appconfig): support for CfnMonitorsProperty in environments Oct 25, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 25, 2023 21:46

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 25, 2023
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!
A couple very minor nits and we should be good to go.

packages/@aws-cdk/aws-appconfig-alpha/lib/environment.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appconfig-alpha/lib/extension.ts Outdated Show resolved Hide resolved
@scanlonp scanlonp self-assigned this Oct 25, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 25, 2023
@mergify mergify bot dismissed scanlonp’s stale review October 26, 2023 14:39

Pull request has been modified.

Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d8159f4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 05f3453 into aws:main Oct 26, 2023
9 checks passed
@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@chenjane-dev chenjane-dev deleted the cfn-monitors-support branch October 26, 2023 16:07
mrgrain pushed a commit that referenced this pull request Nov 1, 2023
)

Adding support to associate our L1 monitors constructs (CfnMonitorsProperty) to a L2 environment construct.

**BREAKING CHANGE**
To define monitors under an environment, you now need to call a static method on `Monitor`.
Example:

```
new Environment(this, 'MyEnv', {
   ....
   monitors: [
      Monitor.fromCloudWatchAlarm(...),
      Monitor.fromCfnMonitorProperty(...),
   ],
});
```

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants