Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigatewayv2): trigger on websocket connect and disconnect is not working #27732

Merged
merged 22 commits into from
Nov 1, 2023

Conversation

sumupitchayan
Copy link
Contributor

Closes #19532

Lambda integrations for $connect and $disconnect routes were previously broken. Users would see this error message in the Lambda console:

160185676-15ba5704-a7ba-49ef-b457-bb3f89094de6

Fixing the path by removing the extra */ from the code of the Lambda integration that adds permission, we no longer see that error message in the Lambda console as the path is now correct:

Screenshot 2023-10-27 at 2 58 11 PM

I could not manage to figure out how to verify this change via an Integration test assertion. However, I added a new integration test file for Lambda $connect and $disconnect integrations on a WebSocketApi. The attached screenshots above also verify that this change works when I manually run it locally.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 27, 2023 19:01
@github-actions github-actions bot added bug This issue is a bug. p1 labels Oct 27, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 27, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 30, 2023 17:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@sumupitchayan sumupitchayan marked this pull request as ready for review October 31, 2023 20:47
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 31, 2023
Copy link
Contributor

mergify bot commented Nov 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 1, 2023
Copy link
Contributor

mergify bot commented Nov 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2c7614a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 89f4f86 into main Nov 1, 2023
12 checks passed
@mergify mergify bot deleted the sumughan/apigwv2-addroutes-integration-not-working branch November 1, 2023 16:15
Copy link
Contributor

mergify bot commented Nov 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(@aws-cdk/aws-apigatewayv2-alpha): Cannot get API Gateway to trigger connect or disconnect
3 participants