test(redshift): unit tests for cluster parameter change reboot handler #27788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
distinguished-contributor
aws-cdk-automation
added
the
pr/needs-community-review
scanlonp
reviewed
Nov 2, 2023
Comment on lines
234
to
262
| test('retries if rebootCluster throws generic error', async () => { | ||
| // GIVEN | ||
| mockDescribeClusters.mockImplementation(() => { | ||
| return { | ||
| Clusters: [{ | ||
| ClusterParameterGroups: [{ | ||
| ParameterGroupName: 'parameter-group-name', | ||
| ParameterApplyStatus: 'pending-reboot', | ||
| }], | ||
| }], | ||
| }; | ||
| }); | ||
| mockRebootCluster.mockImplementation(async () => { | ||
| return Promise.reject(new Error('error')); | ||
| }); | ||
|
|
||
| const event: Partial<AWSLambda.CloudFormationCustomResourceEvent> = { | ||
| RequestType: 'Create', | ||
| ResourceProperties: { | ||
| ServiceToken: 'service-token', | ||
| ClusterId: 'cluster-id', | ||
| ParameterGroupName: 'parameter-group-name', | ||
| }, | ||
| }; | ||
|
|
||
| // WHEN | ||
| // THEN | ||
| await expect(() => invokeHandler(event)).rejects.toThrow('error'); | ||
| }); |
There was a problem hiding this comment.
Could you elaborate on this test? How is this retrying? It looks like it is just failing.
There was a problem hiding this comment.
You're right, I gave the wrong description.
Thanks for the hint 💪
aws-cdk-automation
removed
the
pr/needs-community-review
scanlonp
approved these changes
Nov 2, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27730.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license