Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iam): migrate oidc handler #27820

Closed
wants to merge 4 commits into from
Closed

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Nov 3, 2023

This PR moves the oidc handler from aws-cdk-lib to our new centralized location for custom resource handlers in the https://github.com/aws-cdk package.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 3, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 3, 2023 06:25
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 3, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@colifran colifran added pr/do-not-merge This PR should not be merged at this time. handler-migration labels Nov 3, 2023
@colifran colifran changed the title chore(iam): migrate oidc handler to centralized location for custom resource handlers in @aws-cdk chore(iam): migrate oidc handler to centralized location for custom resource handlers in aws-cdk Nov 3, 2023
@colifran colifran changed the title chore(iam): migrate oidc handler to centralized location for custom resource handlers in aws-cdk chore(iam): migrate oidc handler Nov 6, 2023
@colifran colifran marked this pull request as draft November 7, 2023 17:44
@colifran colifran marked this pull request as ready for review November 17, 2023 17:50
@colifran colifran changed the title chore(iam): migrate oidc handler chore: migrate oidc handler Nov 17, 2023
@colifran colifran changed the title chore: migrate oidc handler chore(iam): migrate oidc handler Nov 17, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@colifran colifran closed this Nov 17, 2023
@colifran colifran deleted the colifran/migrate-oidc-provider branch November 17, 2023 18:14
@colifran colifran restored the colifran/migrate-oidc-provider branch November 17, 2023 18:14
@colifran colifran deleted the colifran/migrate-oidc-provider branch November 17, 2023 18:15
@colifran colifran restored the colifran/migrate-oidc-provider branch November 17, 2023 18:15
@colifran colifran deleted the colifran/migrate-oidc-provider branch November 17, 2023 18:15
Copy link
Contributor

mergify bot commented Nov 17, 2023

⚠️ The sha of the head commit of this PR conflicts with #28052. Mergify cannot evaluate rules on this PR. ⚠️

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1299567
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. handler-migration p2 pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants