Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cdk): update ADOT Lambda Layer ARNs #27849

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Conversation

vasireddy99
Copy link
Contributor

Update ADOT Lambda Layer ARNs of latest release.

References -


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 6, 2023 05:32
@github-actions github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK p2 labels Nov 6, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@vasireddy99 vasireddy99 changed the title Update ADOT Lambda Layer ARNs chore(aws-cdk) -Update ADOT Lambda Layer ARNs Nov 6, 2023
@vasireddy99 vasireddy99 changed the title chore(aws-cdk) -Update ADOT Lambda Layer ARNs chore(aws-cdk): Update ADOT Lambda Layer ARNs Nov 6, 2023
@vasireddy99
Copy link
Contributor Author

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 6, 2023
@vasireddy99 vasireddy99 changed the title chore(aws-cdk): Update ADOT Lambda Layer ARNs chore(cdk): Update ADOT Lambda Layer ARNs Nov 6, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 6, 2023 05:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 7, 2023
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you point me to the documentation that corresponds to which regions are enabled for each layer. I see that a number of regions are commented out, but there are more enabled than in the table from your documentation links. For example https://aws-otel.github.io/docs/getting-started/lambda/lambda-python has 16 regions but the table has 22.

@scanlonp scanlonp self-assigned this Nov 7, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 7, 2023
@mergify mergify bot dismissed scanlonp’s stale review November 8, 2023 16:59

Pull request has been modified.

@vasireddy99
Copy link
Contributor Author

Looks good. Could you point me to the documentation that corresponds to which regions are enabled for each layer. I see that a number of regions are commented out, but there are more enabled than in the table from your documentation links. For example https://aws-otel.github.io/docs/getting-started/lambda/lambda-python has 16 regions but the table has 22.

The doc you referred is correct - https://aws-otel.github.io/docs/getting-started/lambda/lambda-python. thanks for the good catch. updated the fact-table. it should reflect the appropriate (16 regions) now :-)

Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the last test in adot.test.ts is failing. Do you get this error locally?

@scanlonp
Copy link
Contributor

scanlonp commented Nov 8, 2023

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 8, 2023

update

✅ Branch has been successfully updated

@vasireddy99
Copy link
Contributor Author

vasireddy99 commented Nov 9, 2023

It looks like the last test in adot.test.ts is failing. Do you get this error locally?

image

tests are passing now in local

@scanlonp
Copy link
Contributor

scanlonp commented Nov 9, 2023

I cannot find where the build is failing. It looks like all the tests are passing. Let us see if retrying solves it.

@scanlonp scanlonp changed the title chore(cdk): Update ADOT Lambda Layer ARNs chore(cdk): update ADOT Lambda Layer ARNs Nov 9, 2023
@scanlonp scanlonp removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 9, 2023
@vasireddy99
Copy link
Contributor Author

I cannot find where the build is failing. It looks like all the tests are passing. Let us see if retrying solves it.

I have fixed the unit tests iin adot.test.ts, i guess this will pass now.

Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ee35f45
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 54fddd0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4dce764 into aws:main Nov 9, 2023
18 checks passed
@vasireddy99 vasireddy99 deleted the lambdaArns35 branch November 9, 2023 18:45
mikewrighton pushed a commit that referenced this pull request Nov 13, 2023
Update ADOT Lambda Layer ARNs of latest release.

References - 

- aws-otel/aws-otel.github.io#665
- aws-observability/aws-otel-lambda#763
- aws-observability/aws-otel-lambda#762

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants