Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): add missing rds engine versions #27908

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

sakurai-ryo
Copy link
Contributor

This Pull Request will add supported RDS engine versions.

Added engine versions are as follows.

$ aws rds describe-db-engine-versions \
--query "DBEngineVersions[?EngineVersion=='5.7.44'||EngineVersion=='8.0.35'].[DBEngineVersionDescription,EngineVersion,Status]" \
--engine mysql
[
    [
        "MySQL 5.7.44",
        "5.7.44",
        "available"
    ],
    [
        "MySQL 8.0.35",
        "8.0.35",
        "available"
    ]
]

$ aws rds describe-db-engine-versions \
--query "DBEngineVersions[?EngineVersion=='15.00.4322.2.v1'||EngineVersion=='15.00.4335.1.v1'].[DBEngineVersionDescription,EngineVersion,Status]" \
--engine sqlserver-ee
[
    [
        "SQL Server 2019 15.00.4322.2.v1",
        "15.00.4322.2.v1",
        "available"
    ],
    [
        "SQL Server 2019 15.00.4335.1.v1",
        "15.00.4335.1.v1",
        "available"
    ]
]

$ aws rds describe-db-engine-versions \
--query "DBEngineVersions[?EngineVersion=='19.0.0.0.ru-2023-07.rur-2023-07.r1'||EngineVersion=='19.0.0.0.ru-2023-10.rur-2023-10.r1'].[DBEngineVersionDescription,EngineVersion,Status]" \
--engine oracle-ee-cdb
[
    [
        "Oracle 19.0.0.0.ru-2023-07.rur-2023-07.r1",
        "19.0.0.0.ru-2023-07.rur-2023-07.r1",
        "available"
    ],
    [
        "Oracle 19.0.0.0.ru-2023-10.rur-2023-10.r1",
        "19.0.0.0.ru-2023-10.rur-2023-10.r1",
        "available"
    ]
]


$ aws rds describe-db-engine-versions \
--query "DBEngineVersions[?EngineVersion=='21.0.0.0.ru-2023-07.rur-2023-07.r1'||EngineVersion=='21.0.0.0.ru-2023-10.rur-2023-10.r1'].[DBEngineVersionDescription,EngineVersion,Status]" \
--engine oracle-ee-cdb
[
    [
        "Oracle 21.0.0.0.ru-2023-07.rur-2023-07.r1",
        "21.0.0.0.ru-2023-07.rur-2023-07.r1",
        "available"
    ],
    [
        "Oracle 21.0.0.0.ru-2023-10.rur-2023-10.r1",
        "21.0.0.0.ru-2023-10.rur-2023-10.r1",
        "available"
    ]
]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 9, 2023 07:17
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Nov 9, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 9, 2023
@go-to-k
Copy link
Contributor

go-to-k commented Nov 9, 2023

Thanks, sounds nice!

Just to be sure, could you please post any release notes or reference pages?

@sakurai-ryo
Copy link
Contributor Author

@go-to-k
Thank you for your review!
The following versions are mentioned in the documentation or release notes.

MySQL
5.7.44
https://aws.amazon.com/about-aws/whats-new/2023/11/amazon-rds-mysql-new-minor-version-5-7-44

Oracle
19.0.0.0.ru-2023-07.rur-2023-07.r1
19.0.0.0.ru-2023-10.rur-2023-10.r1
https://docs.aws.amazon.com/AmazonRDS/latest/OracleReleaseNotes/oracle-version-19-0.html

21.0.0.0.ru-2023-07.rur-2023-07.r1
21.0.0.0.ru-2023-10.rur-2023-10.r1
https://docs.aws.amazon.com/AmazonRDS/latest/OracleReleaseNotes/oracle-version-21-0.html

However, for MySQL v8.0.35 and SQL Server, there is no mention in the documentation, but I can check in the CLI or console.
Is it better to exclude these versions that are not documented from this PR?

SQL Server
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/CHAP_SQLServer.html#SQLServer.Concepts.General.VersionSupport
MySQL
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/MySQL.Concepts.VersionMgmt.html

Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for listing docs!

However, for MySQL v8.0.35 and SQL Server, there is no mention in the documentation, but I can check in the CLI or console.
Is it better to exclude these versions that are not documented from this PR?

You can also use the describe-db-engine-versions AWS CLI command to see a list of supported versions, as well as defaults for newly created DB instances.

The SQL Server documentation states that the describe-db-engine-versions AWS CLI command can be used to check for supported versions. (And you have already done it.)

Also, if they are not beta versions and can be checked successfully in the CLI or console as well as any other versions, I would be good.

Therefore, I approve it in my review.

Thank you for the contribution!

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 9, 2023
scanlonp
scanlonp previously approved these changes Nov 9, 2023
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I think the cli check is sufficient to know they are supported.

Thanks!

Copy link
Contributor

mergify bot commented Nov 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 9, 2023
Copy link
Contributor

mergify bot commented Nov 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@scanlonp scanlonp self-assigned this Nov 10, 2023
@mergify mergify bot dismissed scanlonp’s stale review November 10, 2023 01:46

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: acada89
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0220a76 into aws:main Nov 10, 2023
11 checks passed
mikewrighton pushed a commit that referenced this pull request Nov 13, 2023
This Pull Request will add supported RDS engine versions.

Added engine versions are as follows.
```sh
$ aws rds describe-db-engine-versions \
--query "DBEngineVersions[?EngineVersion=='5.7.44'||EngineVersion=='8.0.35'].[DBEngineVersionDescription,EngineVersion,Status]" \
--engine mysql
[
    [
        "MySQL 5.7.44",
        "5.7.44",
        "available"
    ],
    [
        "MySQL 8.0.35",
        "8.0.35",
        "available"
    ]
]

$ aws rds describe-db-engine-versions \
--query "DBEngineVersions[?EngineVersion=='15.00.4322.2.v1'||EngineVersion=='15.00.4335.1.v1'].[DBEngineVersionDescription,EngineVersion,Status]" \
--engine sqlserver-ee
[
    [
        "SQL Server 2019 15.00.4322.2.v1",
        "15.00.4322.2.v1",
        "available"
    ],
    [
        "SQL Server 2019 15.00.4335.1.v1",
        "15.00.4335.1.v1",
        "available"
    ]
]

$ aws rds describe-db-engine-versions \
--query "DBEngineVersions[?EngineVersion=='19.0.0.0.ru-2023-07.rur-2023-07.r1'||EngineVersion=='19.0.0.0.ru-2023-10.rur-2023-10.r1'].[DBEngineVersionDescription,EngineVersion,Status]" \
--engine oracle-ee-cdb
[
    [
        "Oracle 19.0.0.0.ru-2023-07.rur-2023-07.r1",
        "19.0.0.0.ru-2023-07.rur-2023-07.r1",
        "available"
    ],
    [
        "Oracle 19.0.0.0.ru-2023-10.rur-2023-10.r1",
        "19.0.0.0.ru-2023-10.rur-2023-10.r1",
        "available"
    ]
]


$ aws rds describe-db-engine-versions \
--query "DBEngineVersions[?EngineVersion=='21.0.0.0.ru-2023-07.rur-2023-07.r1'||EngineVersion=='21.0.0.0.ru-2023-10.rur-2023-10.r1'].[DBEngineVersionDescription,EngineVersion,Status]" \
--engine oracle-ee-cdb
[
    [
        "Oracle 21.0.0.0.ru-2023-07.rur-2023-07.r1",
        "21.0.0.0.ru-2023-07.rur-2023-07.r1",
        "available"
    ],
    [
        "Oracle 21.0.0.0.ru-2023-10.rur-2023-10.r1",
        "21.0.0.0.ru-2023-10.rur-2023-10.r1",
        "available"
    ]
]
```
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants