Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-dotnet): Add .NET Lambda support #27979

Closed
wants to merge 14 commits into from

Conversation

vlesierse
Copy link
Contributor

@vlesierse vlesierse commented Nov 14, 2023

Adds support .NET Lambda functions as described in the issue #23236 and RFC Issue aws/aws-cdk-rfcs/issues/469. This feature is introduced as new alpha package @aws-cdk/aws-lambda-dotnet-alpha

  • Code
  • Tests
  • Documentation

Closes #23236.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Nov 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 14, 2023 10:06
@github-actions github-actions bot added effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 labels Nov 14, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 16, 2023 21:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@kaizencc
Copy link
Contributor

Hi @vlesierse, thanks for opening this PR. We're still debating this a bit internally but wanted to provide some update for you:

We're most likely going to figure out a way to help you release this as a self-published module. It's not that we don't want it, but we don't think it belongs in the aws-cdk repo, since it is not strictly an L2.

But wait, what about aws-lambda-python, aws-lambda-go, aws-lambda-nodejs?

Good question -- we allowed those modules into the main cdk repo when we were still experimenting with what made sense to be included and what didn't. Looking back, we probably wish we had pulled them out into separate repositories, but they must continue to be included for legacy reasons. If we ever release a new major version of CDK, we'd likely move these modules out on their own.

So -- nothing actionable yet, but I didn't want to keep you hanging. In the meantime, I notice the build is failing, which is something that would need fixing anyways :)

Cheers.

@vlesierse
Copy link
Contributor Author

vlesierse commented Nov 18, 2023

@kaizencc

Thank you for your transparency and providing an update and considerations the team is currently working with. Happy work on continuing bringing this feature to CDK in whatever form. Obviously giving .NET the same treatment as Go & Python at the moment is my preference...

@vlesierse
Copy link
Contributor Author

vlesierse commented Nov 19, 2023

@kaizencc on the note of the failing build, it currently fails in the install phase in CodeBuild with Error while executing command: npm config set unsafe-perm true. Reason: exit status 1.
Is there something I can do to fix this? Looks not to be code related.

Update
It appears that some CodeBuild jobs are running on a new Debian version where NPM doesn't support unsafe-perm=true. After removing this from the install phase, the build succeeds. It might be considered to drop this from the .buildspec files.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 19, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b7675c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kaizencc
Copy link
Contributor

Hi @vlesierse, we are prepared to go forward with you on a separate cdklabs repository for lambda-dotnet. I've created it here: https://github.com/cdklabs/awscdk-lambda-dotnet. Feel free to create a PR on that repo (it might need some maintenance work that I'm doing right now) and/or contact me on cdk.dev if you need additional support.

@vlesierse
Copy link
Contributor Author

Hi @vlesierse, we are prepared to go forward with you on a separate cdklabs repository for lambda-dotnet. I've created it here: https://github.com/cdklabs/awscdk-lambda-dotnet. Feel free to create a PR on that repo (it might need some maintenance work that I'm doing right now) and/or contact me on cdk.dev if you need additional support.

@kaizencc that this greatly appreciated. I'll finished some cleanup, additional documentation and tests in a PR to the repository. Thank you!

@kaizencc
Copy link
Contributor

Sounds great! I'm gonna close this PR since it's not going to get merged in to cdk proper, and see you on the cdklabs repo. @vlesierse note that the cdklabs repo is governed by projen so all project configuration goes into the .projenrc.ts file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-lambda): Support for .NET Lambda functions with included bundling
3 participants