Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: workflow to protect the metadata.ts file against manual changes #27989

Closed
wants to merge 1 commit into from

Conversation

otaviomacedo
Copy link
Contributor

This new workflow protects the region-info metadata file, so that only the user github-actions[bot] can change it.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 14, 2023 16:29
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 14, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2d888c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 14, 2023
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we investigate making this part of the PR linter? I'd rather have it all in once place than spread around a lot of workflow scripts.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 15, 2023
@otaviomacedo
Copy link
Contributor Author

Did we investigate making this part of the PR linter? I'd rather have it all in once place than spread around a lot of workflow scripts.

You're absolutely right. There you go: #28007.

@otaviomacedo otaviomacedo deleted the otaviom/protect-metadata branch January 11, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants