Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): support RDS for SQL Server 14.00.3465.1.v1, 13.00.6435.1.v1 and 12.00.6449.1.v1 #28085

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Nov 21, 2023

This PR supports minor versions for RDS for SQL Server.

  • SQL Server 2014 SP3 CU4 GDR - 12.0.6449.1
  • SQL Server 2016 SP3 GDR - 13.0.6435.1
  • SQL Server 2017 CU31 GDR - 14.0.3465.1
  • (SQL Server 2019 CU23 - 15.0.4335.1)
    • This has already been added to the CDK.

https://aws.amazon.com/about-aws/whats-new/2023/11/amazon-rds-sql-server-supports-minor-versions/?nc1=h_ls

❯ aws rds describe-db-engine-versions \
∙ --engine sqlserver-ee \
∙ --query "DBEngineVersions[?EngineVersion=='14.00.3465.1.v1'||EngineVersion=='13.00.6435.1.v1'||EngineVersion=='12.00.6449.1.v1'].[DBEngineVersionDescription,EngineVersion,DBParameterGroupFamily,MajorEngineVersion,Status]"

[
    [
        "SQL Server 2014 12.00.6449.1.v1",
        "12.00.6449.1.v1",
        "sqlserver-ee-12.0",
        "12.00",
        "available"
    ],
    [
        "SQL Server 2016 13.00.6435.1.v1",
        "13.00.6435.1.v1",
        "sqlserver-ee-13.0",
        "13.00",
        "available"
    ],
    [
        "SQL Server 2017 14.00.3465.1.v1",
        "14.00.3465.1.v1",
        "sqlserver-ee-14.0",
        "14.00",
        "available"
    ]
]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Nov 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 21, 2023 05:40
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 21, 2023
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @go-to-k

Copy link
Contributor

mergify bot commented Nov 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 21, 2023
Copy link
Contributor

mergify bot commented Nov 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 58805f5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 986f54c into aws:main Nov 21, 2023
9 checks passed
Copy link
Contributor

mergify bot commented Nov 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants