chore(redshift-alpha): migrate database query handlers #28130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
There was a problem hiding this comment.
Hey, just some clarification questions as comments.
I also wanted to understand, if the following files are new or were just moved for migration:
- packages/@aws-cdk/custom-resource-handlers/lib/aws-redshift-alpha/database-query-handlers/handler-props.ts
- packages/@aws-cdk/custom-resource-handlers/lib/aws-redshift-alpha/database-query-handlers/types.ts
- packages/@aws-cdk/custom-resource-handlers/lib/aws-redshift-alpha/database-query-handlers/util.ts
| @@ -46,7 +46,7 @@ jest.mock('@aws-sdk/client-secrets-manager', () => ({ | |||
| }, | |||
| })); | |||
|
|
|||
| import { handler as manageUser } from '../../lib/private/database-query-provider/user'; | |||
| import { handler as manageUser } from '../../../lib/aws-redshift-alpha/database-query-handlers/user'; | |||
There was a problem hiding this comment.
Changing this to 'database-query-handlers' would be breaking change for users when importing. We should add that to the PR.
| @@ -0,0 +1,39 @@ | |||
| import { Column, TableDistStyle, TableSortStyle } from './types'; | |||
|
|
|||
| export type ClusterProps = Omit<DatabaseQueryHandlerProps, 'handler'>; | |||
There was a problem hiding this comment.
I am surprised Omit works with JSII. Can you confirm this?
| @@ -6,7 +6,7 @@ import { ICluster } from './cluster'; | |||
| import { DatabaseOptions } from './database-options'; | |||
| import { DatabaseSecret } from './database-secret'; | |||
| import { DatabaseQuery } from './private/database-query'; | |||
| import { HandlerName } from './private/database-query-provider/handler-name'; | |||
| import { HandlerName } from './private//handler-name'; | |||
There was a problem hiding this comment.
Also do you have context why these are named private and handler-name?
There was a problem hiding this comment.
Can this instead be a constants.ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the database query handlers to our new centralized location for custom resource handlers in the @aws-cdk package.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license