fix(core): max resources quota enforced on nested stacks

[lpizzinidev]

The max resource quota of 500 should not be applied on nested stacks.
AWS CloudFormation quotas.

Closes #28186.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[lpizzinidev]

Exemption Request.
Unit tests should provide enough coverage here.

[scanlonp]

@lpizzinidev I am a little concerned that the interpretation of the docs are wrong in the original issue. In my mind, there is a difference between a nested stack and a child stack. The nested stack is the entire structure, which is made up of parent and child stacks, similar to a tree vs nodes. It does not seem plausible that just because a single stack is a child stack, that its resource limit jumps from 500 to 2500. I believe the 2500 limit is of the entire nested structure.

I think an integ test, for verification at least, is necessary. If you would like to set this up, feel free. I have been told CloudFormation::WaitConditionHandle is a good lightweight resource to make many of. If you do not feel comfortable provisioning this many resources, one of the team members can try to do so.

[lpizzinidev]

@scanlonp
Makes sense.
Now that I have reviewed it, the MAX_RESOURCES = 500 limit seems correct.
We should probably enforce the 2500 limit only if the stack is nested.

[scanlonp]

@lpizzinidev, sounds good. This could just be something we let cloudformation enforce. I doubt too many users will be running into the 2500 resource limit.

[lpizzinidev]

@scanlonp
Yeah, probably the best approach here is to not validate the number of resources if the stack is nested.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: b431586
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[scanlonp]

I still think this is a no-op. Commented here #28186 (comment).

[lpizzinidev]

Closing due to #28186 (comment)