Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): cdk diff falsely reports resource replacements on trivial template changes #28336

Merged
merged 51 commits into from
Jan 4, 2024
Merged

fix(cli): cdk diff falsely reports resource replacements on trivial template changes #28336

merged 51 commits into from
Jan 4, 2024

Commits on Dec 1, 2023

  1. can now create changeset during diff

    @comcalvi
    comcalvi committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    b299958 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. working changeset diff for resource replacement, but not for property… 

    … replacement
    @comcalvi
    comcalvi committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    9f73241 View commit details
    Browse the repository at this point in the history

  2. property-level diff

    @comcalvi
    comcalvi committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    b59e97f View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. removed resource metadata from diff, we now consider evaluation: dyna… 

    …mic vs evaluation: direct to show supposedly always replacement updates that are actually 'maybe' updates
    @comcalvi
    comcalvi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    850fd0f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/changeset… 

    …-diff
    @comcalvi
    comcalvi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    858abcc View commit details
    Browse the repository at this point in the history

  3. diff now evaluates fn::getAtt short form and long form equivalence

    @comcalvi
    comcalvi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    edd8dc3 View commit details
    Browse the repository at this point in the history

  4. refactor

    @comcalvi
    comcalvi committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    7f5cec0 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. dependson is another problem...

    @comcalvi
    comcalvi committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    f7f8d15 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. tests, pt 1

    @comcalvi
    comcalvi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    49e890c View commit details
    Browse the repository at this point in the history

  2. cleanup

    @comcalvi
    comcalvi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5129e95 View commit details
    Browse the repository at this point in the history

  3. move to devDeps

    @comcalvi
    comcalvi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    4c66a1e View commit details
    Browse the repository at this point in the history

  4. yarn.lock

    @comcalvi
    comcalvi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d373680 View commit details
    Browse the repository at this point in the history

  5. clean

    @comcalvi
    comcalvi committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    03a79f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. refactor

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7c6287b View commit details
    Browse the repository at this point in the history

  2. CLI options

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    da00e1a View commit details
    Browse the repository at this point in the history

  3. remove metadata, but only when the flag is passed

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    212f603 View commit details
    Browse the repository at this point in the history

  4. not sure who uses this, but someone might...

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9d01051 View commit details
    Browse the repository at this point in the history

  5. console

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    73c4685 View commit details
    Browse the repository at this point in the history

  6. conflicts

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    29d9094 View commit details
    Browse the repository at this point in the history

  7. cleanup

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    3096aec View commit details
    Browse the repository at this point in the history

  8. added the SDK comment

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a106c7d View commit details
    Browse the repository at this point in the history

  9. style

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e6e770d View commit details
    Browse the repository at this point in the history

  10. test comment cleanup

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    054e432 View commit details
    Browse the repository at this point in the history

  11. tests

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    561663d View commit details
    Browse the repository at this point in the history

  12. TS

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    5d44f9a View commit details
    Browse the repository at this point in the history

  13. bleh

    @comcalvi
    comcalvi committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    64e918b View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. cleanup

    @comcalvi
    comcalvi committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    4686b37 View commit details
    Browse the repository at this point in the history

  2. lefotver 

    git
    @comcalvi
    comcalvi committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    d3edce4 View commit details
    Browse the repository at this point in the history

  3. resource to import/...

    @comcalvi
    comcalvi committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    76d9621 View commit details
    Browse the repository at this point in the history

  4. more resources to import

    @comcalvi
    comcalvi committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    645feb2 View commit details
    Browse the repository at this point in the history

  5. naming

    @comcalvi
    comcalvi committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f90ba59 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. rework

    @comcalvi
    comcalvi committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    d186cc9 View commit details
    Browse the repository at this point in the history

  2. testing

    @comcalvi
    comcalvi committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    a81a5dd View commit details
    Browse the repository at this point in the history

  3. error handling

    @comcalvi
    comcalvi committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    52f86a1 View commit details
    Browse the repository at this point in the history

  4. dependsOn

    @comcalvi
    comcalvi committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    7d0d38f View commit details
    Browse the repository at this point in the history

  5. rename

    @comcalvi
    comcalvi committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    dec2261 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. nested stacks

    @comcalvi
    comcalvi committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d1b8533 View commit details
    Browse the repository at this point in the history

  2. depends on improvements + comments

    @comcalvi
    comcalvi committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c9341ea View commit details
    Browse the repository at this point in the history

  3. 1,1

    @comcalvi
    comcalvi committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    ca152bb View commit details
    Browse the repository at this point in the history

  4. done

    @comcalvi
    comcalvi committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    abfe661 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. unit test

    @comcalvi
    comcalvi committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    44041b1 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. rename

    @comcalvi
    comcalvi committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    7b4d7e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. cloudformation wowww

    @comcalvi
    comcalvi committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    5c654da View commit details
    Browse the repository at this point in the history

  2. disable it, just for testing...

    @comcalvi
    comcalvi committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    3bd3b03 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/changeset… 

    …-diff
    @comcalvi
    comcalvi committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    0956232 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/changeset… 

    …-diff
    @comcalvi
    comcalvi committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b07e9ac View commit details
    Browse the repository at this point in the history

  5. removing this fix, for now...

    @comcalvi
    comcalvi committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f0984a6 View commit details
    Browse the repository at this point in the history

  6. comments

    @comcalvi
    comcalvi committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c264294 View commit details
    Browse the repository at this point in the history

  7. nested stack test

    @comcalvi
    comcalvi committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    7ebc5ce View commit details
    Browse the repository at this point in the history

  8. idk what this is doing here...

    @comcalvi
    comcalvi committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b35e538 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Merge branch 'main' into comcalvi/changeset-diff

    @mergify
    mergify[bot] authored Jan 4, 2024
    Configuration menu
    Copy the full SHA
    4f12072 View commit details
    Browse the repository at this point in the history