Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli-integ): example downloads publib from npm #28829

Merged
merged 2 commits into from
Jan 23, 2024
Merged

chore(cli-integ): example downloads publib from npm #28829

merged 2 commits into from
Jan 23, 2024

Conversation

kaizencc
Copy link
Contributor

publib is our package that includes a CLI tool named publib-ca.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 23, 2024 19:51
@github-actions github-actions bot added the p2 label Jan 23, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 23, 2024
@kaizencc kaizencc changed the title chore(@aws-cdk-testing): fix erroneous example to download publib chore(@aws-cdk-testing): example downloads publib from npm Jan 23, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kaizencc kaizencc changed the title chore(@aws-cdk-testing): example downloads publib from npm chore(cli-integ): example downloads publib from npm Jan 23, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 23, 2024 20:00

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9bd8e7f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d6c3a9a into main Jan 23, 2024
12 checks passed
@mergify mergify bot deleted the kaizencc-patch-8 branch January 23, 2024 21:13
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaizencc @aws-cdk-automation @mrgrain