Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): specify PreferredMaintenanceWindow in reader or writer props #29686

Merged
merged 11 commits into from
Apr 5, 2024

Conversation

Konosh93
Copy link
Contributor

@Konosh93 Konosh93 commented Apr 2, 2024

Issue #29687

Closes ##29687

Reason for this change

Since instanceProps is deprecated it is better to allow setting PreferredMaintenanceWindow using writer and readers props.

Description of changes

Added optional preferredMaintenanceWindow field to ClusterInstanceOptions and added a unit test.

Description of how you validated changes

  • Add a single unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Apr 2, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 2, 2024 05:22
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Konosh93
Copy link
Contributor Author

Konosh93 commented Apr 2, 2024

[IMO] Based on the previous fix, I think this PR also qualifies for an Exemption Request.

#29033 (comment)

@msambol
Copy link
Contributor

msambol commented Apr 2, 2024

Can you change the title to:

"feat(rds): specify PreferredMaintenanceWindow in reader or writer props"

Also, this one should have an integration test. Let me know if you need help with that.

@Konosh93 Konosh93 changed the title feat(rds): allow specifying PreferredMaintenanceWindow in RDS cluster instances using the new api feat(rds): specify PreferredMaintenanceWindow in reader or writer props Apr 3, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 3, 2024 05:01

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 3, 2024
@Konosh93
Copy link
Contributor Author

Konosh93 commented Apr 3, 2024

Can you change the title to:

"feat(rds): specify PreferredMaintenanceWindow in reader or writer props"

Sure. Thanks. 👍

Also, this one should have an integration test. Let me know if you need help with that.

I modified an existing test in packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.ts.

@Konosh93 Konosh93 requested a review from msambol April 3, 2024 13:25
Copy link
Contributor

@msambol msambol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 3, 2024
@godwingrs22 godwingrs22 self-requested a review April 5, 2024 17:37
Copy link
Member

@godwingrs22 godwingrs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Konosh93 for your contribution and @msambol for your review.

Copy link
Contributor

mergify bot commented Apr 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 5, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cb4a440
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 615ee2d into aws:main Apr 5, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Apr 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants