Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: elaborate that crossZoneEnabled property cannot be changed for ALB in ELBv2. #29893

Closed
wants to merge 1 commit into from
Closed

docs: elaborate that crossZoneEnabled property cannot be changed for ALB in ELBv2. #29893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/shared/base-load-balancer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export interface BaseLoadBalancerProps {
/**
* Indicates whether cross-zone load balancing is enabled.
*
* @default - false for Network Load Balancers and true for Application Load Balancers.
* @default - false for Network Load Balancers and true for Application Load Balancers (this cannot be changed).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some clarification, I see here and here that there are way to disable crossZone for ALB. Why are we saying this cannot be changed here? If we can change it then this should be implement the change suggested here imo. Let me know if I'm understanding this wrong.

Copy link
Contributor Author

@ashishdhingra ashishdhingra Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaythapa In #29866 (comment) and #29866 (comment), it is mentioned that the crossZone could be disabled at Target Group level per docs and it already works per example. However, it cannot be changed at ALB level per docs.

Both Target Group level and ALB level are different scopes. :)

This PR is only to make it clear in LoadBalancer docs that it cannot be changed at ALB level. @pahud is coming up with consolidated PR for some additional change (in addition to change in this PR).

NOTE: I'm unsure what will happen in CloudFormation deployment if we enforce crossZone to false, when service itself doesn't support disabling it at ALB level (will it fail or will it ignore it).

*/
readonly crossZoneEnabled?: boolean;

Expand Down
Loading