Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): let AsgCapacityProvider use IAutoScalingGroup only when Managed Termination Protection is disable #30335

Merged
merged 12 commits into from
Jun 25, 2024

Commits on May 24, 2024

  1. Let AsgCapacityProvider use IAutoScalingGroup even when Managed Termi…

    …nation Protection is enabled.
    
    The code will emit a warning message but will let the user specify a self managed ASG using `AutoScalingGroup.fromAutoScalingGroupName`.
    Also makes sure that when calling `Cluster.addAsgCapacityProvider`, the ASG used is not an imported one.
    scorbiere committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1d78413 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Configuration menu
    Copy the full SHA
    65aa924 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. fix(core): overrideLogicalId validation (aws#29708)

    ### Issue # (if applicable)
    
    Closes aws#29701
    
    ### Reason for this change
    
    Calling `overrideLogicalId` on a `Construct` with an invalid logical ID ([docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/resources-section-structure.html#resources-section-structure-logicalid)) would not throw an error at synthesis time. CloudFormation would 
    
    ### Description of changes
    
    * Validate `overrideLogicalId` (must not be empty, must not be over 255 characters, must match `/^[A-Za-z0-9]+$/`
    * Document exceptions with `@error` JSDoc tags
    
    ### Description of how you validated changes
    
    I've added unit tests, integration tests should not be necessary
    
    ### Checklist
    - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    nmussy authored and scorbiere committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    d0d05dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d85ce7b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1bf9568 View commit details
    Browse the repository at this point in the history
  4. Fix the doc.

    scorbiere committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    197e8d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Configuration menu
    Copy the full SHA
    e821362 View commit details
    Browse the repository at this point in the history
  2. Update cluster.ts doc string

    Co-authored-by: paulhcsun <[email protected]>
    scorbiere and paulhcsun authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7fd9c3c View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Configuration menu
    Copy the full SHA
    375dfb5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ff1c70 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d600661 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Configuration menu
    Copy the full SHA
    d7d6b58 View commit details
    Browse the repository at this point in the history