Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sns): create subscriptions in consumer scope #3065

Merged
merged 13 commits into from
Jun 27, 2019
Merged

fix(sns): create subscriptions in consumer scope #3065

merged 13 commits into from
Jun 27, 2019

Commits on Jun 25, 2019

  1. fix(sns): create subscriptions in consumer scope 

    Since in most cases the consumer needs to reference the topic to
permit it to send them messages (e.g. invoke a lambda function or send
messages to the queue), it makes much more send to create the SNS subscription
resource on the consumer's scope/stack instead of the topic's.

This change adds an optional `scope` field to `TopicSubscriptionConfig` which
is respected by `topic.addSubscription`. If `scope` is not defined, the topic's
scope will be used. We also changed `subscriberId` to be optional, since in the
case where `scope` is specified, the natural ID for the subscription construct
would be the topic's unique ID, which is now the default. A runtime error will 
be emitted if both `scope` and `subscriberId` are not provided.

Fixes #3064
    Elad Ben-Israel committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    3d8cf59 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Merge branch 'master' into benisrae/fix-subscription-scope

    Elad Ben-Israel authored Jun 26, 2019
    Configuration menu
    Copy the full SHA
    cdf6964 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into benisrae/fix-subscription-scope

    Elad Ben-Israel authored Jun 26, 2019
    Configuration menu
    Copy the full SHA
    68ddbe7 View commit details
    Browse the repository at this point in the history

  3. fix import order

    Elad Ben-Israel committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    740dd1c View commit details
    Browse the repository at this point in the history

  4. update integ tests

    Elad Ben-Israel committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    0149059 View commit details
    Browse the repository at this point in the history

  5. update decdk snapshot

    Elad Ben-Israel committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    f4e090c View commit details
    Browse the repository at this point in the history

  6. update ecs tests

    Elad Ben-Israel committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    1a54571 View commit details
    Browse the repository at this point in the history

  7. update stepfunctions integ tests

    Elad Ben-Israel committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    9f90025 View commit details
    Browse the repository at this point in the history

  8. update events-targets

    Elad Ben-Israel committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    38409fa View commit details
    Browse the repository at this point in the history

  9. fix another integ test

    Elad Ben-Israel committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    7c3d182 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. Merge remote-tracking branch 'origin/master' into benisrae/fix-subscr… 

    …iption-scope
    Elad Ben-Israel committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    227ea9f View commit details
    Browse the repository at this point in the history

  2. update decdk snapshot

    Elad Ben-Israel committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    800aaa0 View commit details
    Browse the repository at this point in the history

  3. fix breaking change

    Elad Ben-Israel committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    dce8b7b View commit details
    Browse the repository at this point in the history