Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipes-targets): add EventBridge #30654

Merged
merged 29 commits into from
Oct 7, 2024
Merged

feat(pipes-targets): add EventBridge #30654

merged 29 commits into from
Oct 7, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Jun 24, 2024 •
edited
Loading

Add EventBridge event bus as a Pipes target.

@aws-cdk-automation aws-cdk-automation requested a review from a team June 24, 2024 22:45
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jun 24, 2024
@msambol msambol force-pushed the pipes-targets-eventbridge branch 2 times, most recently from 5cf3b4f to 1bcc300 Compare June 25, 2024 00:42
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024
nmussy
nmussy suggested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file names should also be camel cased, s/eventBridge/event-bridge/

packages/@aws-cdk/aws-pipes-targets-alpha/lib/eventBridge.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/eventBridge.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/eventBridge.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/eventBridge.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/eventBridge.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/eventBridge.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024
@msambol
Copy link
Contributor Author

msambol commented Jun 25, 2024

@nmussy Updated. Great feedback as always. Thanks!

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

This was referenced Jul 1, 2024
Closed
Closed
@pahud pahud added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 22, 2024
kaizencc
kaizencc previously requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @msambol sorry for the long delay, have a few comment before my stamp of approval!

packages/@aws-cdk/aws-pipes-targets-alpha/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts
export class EventBridgeTarget implements ITarget {
private eventBus: IEventBus;
private eventBridgeParameters?: EventBridgeTargetParameters;
public readonly targetArn: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public readonly targetArn: string;
public readonly targetArn: string;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to the spacing since this is a public prop it should have a docstring... shouldn't the linter have picked up on that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaizencc I think because it's here ? https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-pipes-alpha/lib/target.ts#L19-L22. not entirely sure.

packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts Show resolved Hide resolved
@mergify mergify bot dismissed kaizencc’s stale review September 5, 2024 02:36

Pull request has been modified.

@msambol
Copy link
Contributor Author

msambol commented Sep 5, 2024

@kaizencc – Update per your feedback. Thanks for the review!

@msambol
Copy link
Contributor Author

msambol commented Sep 24, 2024

@kaizencc mind giving this another pass?

@msambol
Copy link
Contributor Author

msambol commented Sep 28, 2024

@kaizencc I updated the integration test to incorporate feedback by @moelasmar on #30756.

@msambol
Copy link
Contributor Author

msambol commented Oct 4, 2024

@Leo10Gama Could we get this one in next?

Leo10Gama
Leo10Gama reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Aside from a few minor typos, it looks pretty good to me

packages/@aws-cdk/aws-pipes-targets-alpha/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/lib/event-bridge.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/test/event-bridge.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-pipes-targets-alpha/test/event-bridge.test.ts Outdated Show resolved Hide resolved
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7aa72b0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Leo10Gama
Leo10Gama approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 842f49a into aws:main Oct 7, 2024
13 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nmussy nmussy nmussy requested changes

@Leo10Gama Leo10Gama Leo10Gama approved these changes

@kaizencc kaizencc kaizencc left review comments

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@msambol @aws-cdk-automation @nmussy @kaizencc @Leo10Gama @pahud