Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix broken test in Java init template #3108

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

shivlaks
Copy link
Contributor

Follow-up to address changes introduced in #3065


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Follow-up to address changes introduced in #3065
@shivlaks shivlaks requested review from skinny85, eladb and a team June 27, 2019 20:16
@ghost ghost removed their request for review June 27, 2019 20:16
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -62,6 +56,12 @@
}
}
},
"MyFirstTopic0ED1F8A4": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this back up? The diff will be smaller this way :)

@shivlaks shivlaks merged commit f696efc into master Jun 27, 2019
@shivlaks shivlaks deleted the shivlaks/fix-java-init-template branch June 28, 2019 09:27
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants