Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cognito): add tags property for user pool #31108

Closed
wants to merge 5 commits into from

Conversation

kdnakt
Copy link
Contributor

@kdnakt kdnakt commented Aug 14, 2024

Issue # (if applicable)

Reason for this change

The userPoolTags property existed in the L1 construct but was not present in the L2 construct

Description of changes

Add the tags property for UserPool

Description of how you validated changes

Added a unit test and an integration test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 14, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 14, 2024 15:33
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Aug 14, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review August 15, 2024 01:42

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 15, 2024
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've added 2 minor comments.

kdnakt and others added 2 commits October 5, 2024 21:34
…t/integ.user-pool-tags.ts

Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>
@kdnakt
Copy link
Contributor Author

kdnakt commented Oct 5, 2024

@badmintoncryer Thank you for the suggestion, I've just committed them.

Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5ae2e4f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 5, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In L2 construct, we don't directly provide tags property even though it's supported in the relevant L1 construct.

The typical way of adding tag is through Tags.of(this).add. Does this method work for you?

@kdnakt
Copy link
Contributor Author

kdnakt commented Oct 12, 2024

Thank you, the Tags.of(this).add solution worked for me.
Would you recommend that I close this PR now?

@GavinZZ
Copy link
Contributor

GavinZZ commented Oct 12, 2024

As a side note, if you use this, it will default to result in tags being added at stack level this propagating to all resources created in the stack.

If this is not the ideal solution you could also do Tags.of(resource).

Let’s close this PR as I believe this change is not needed anymore.

@kdnakt kdnakt closed this Oct 12, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants