chore(route53): correct typo in route53 const #31330
Conversation
This updates "@aws-cdk/aws-route53-patters" to "@aws-cdk/aws-route53-patterns"
github-actions
bot
added
the
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
crs-k
changed the title
crs-k
changed the title
crs-k
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -74,7 +74,7 @@ export const ENABLE_PARTITION_LITERALS = '@aws-cdk/core:enablePartitionLiterals' | |||
| export const EVENTS_TARGET_QUEUE_SAME_ACCOUNT = '@aws-cdk/aws-events:eventsTargetQueueSameAccount'; | |||
| export const ECS_DISABLE_EXPLICIT_DEPLOYMENT_CONTROLLER_FOR_CIRCUIT_BREAKER = '@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker'; | |||
| export const S3_SERVER_ACCESS_LOGS_USE_BUCKET_POLICY = '@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy'; | |||
| export const ROUTE53_PATTERNS_USE_CERTIFICATE = '@aws-cdk/aws-route53-patters:useCertificate'; | |||
| export const ROUTE53_PATTERNS_USE_CERTIFICATE = '@aws-cdk/aws-route53-patterns:useCertificate'; | |||
There was a problem hiding this comment.
Thanks for fixing this typo, but I believe we could not accept this change, as it is a breaking change.
moelasmar
added
the
closing-soon
|
Comments on closed issues and PRs are hard for our team to see. |
This updates "@aws-cdk/aws-route53-patters" to "@aws-cdk/aws-route53-patterns"
Issue # (if applicable)
n/a
Reason for this change
Typo is carried throughout most documentation but is difficult to find when manually adding feature flags or similar references.
Description of changes
No important decisions, just correcting the typo.
Description of how you validated changes
I have not added any additional tests, but did update a unit test to use the correct spelling.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license