fix(cli): deployment errors are printed 3 times #31389
Conversation
The CLI prints deployment errors 3 times. This is caused by an catching an error, printing it, and then throwing it again; to another `catch` statement that catches the error, prints it, and then throws it again. In this PR, get rid of one catch and change the error that gets rethrown in a different case. Also in this PR: fix the inconsistency of printing the progress of asset publishing. Compared to the progress of stack deployments, the stack name isn't bold and there is a single space offset.
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
rix0rrr
added
pr-linter/exempt-test
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
rix0rrr
force-pushed
the
huijbers/reduce-error-printing
branch
from
7233e6f
to
4fdb1a6
Compare
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
rix0rrr
added
the
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
removed
the
pr/needs-cli-test-run
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
The CLI prints deployment errors 3 times. This is caused by an catching an error, printing it, and then throwing it again; to another
catchstatement that catches the error, prints it, and then throws it again.In this PR, get rid of one catch and change the error that gets rethrown in a different case.
Also in this PR: fix the inconsistency of printing the progress of asset publishing. Compared to the progress of stack deployments, the stack name isn't bold and there is a single space offset.
(A little work to change the printing, a LOT of work to get the integration+regression tests to pass, that all assert way too many specifics about the error messages that get printed to the screen)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license