chore: update jsii to 0.13.2 #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
eladb
suggested changes
Jul 1, 2019
There was a problem hiding this comment.
I fixed the .npmignore files (just removed the .jsii line instead of a new "!.jsii" line).
Would be good to enforce this with .npmignore...
Also, @rix0rrr if the new version already includes all the fixes to vendored_deps/jsii-diff-0.13.x.tgz, then we can just remove it (or does it still contain some changes that are not published, in which case we shouldn't override it here).
|
|
||
| # Include .jsii | ||
| !.jsii |
There was a problem hiding this comment.
Looks odd... we have .jsii excluded and then included? It should be included (!!)
Can we enforce with pkglint?
|
Since "master" is broken right now, I'll merge this in and we should follow up with a pkglint fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license