-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eks): update nodegroup gpu check #31445
base: main
Are you sure you want to change the base?
chore(eks): update nodegroup gpu check #31445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @AlexKaracaoglu - I think adding an Integ test or modifying and existing one to use this new Instance Type would be nice to confirm that it successfully deploys.
Also, can you add a unit test for the isGpuInstanceType
function?
Not sure if you are still on it but you can refer to this commit I made |
@pahud @sumupitchayan - Appreciate the follow ups, I'll get some changes in later today |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #31347.
Reason for this change
The motivating bug is that you cannot add a combo of g5 and a g6 as instance classes onto the same node group or else the following error will be thrown:
instanceTypes of different architectures is not allowed
.Description of changes
isGpuInstanceType
checkDescription of how you validated changes
Wrote unit tests for the
isGpuInstanceType
functionChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license