feat(vpcv2): vpc peering connection construct #31645
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| peeringRole.addToPolicy(new PolicyStatement({ | ||
| effect: Effect.ALLOW, | ||
| actions: ['ec2:AcceptVpcPeeringConnection'], | ||
| resources: [`arn:${Aws.PARTITION}:ec2:${this.region}:${this.ownerAccountId}:vpc/${this.vpcId}`], | ||
| })); | ||
|
|
||
| peeringRole.addToPolicy(new PolicyStatement({ | ||
| actions: ['ec2:AcceptVpcPeeringConnection'], | ||
| effect: Effect.ALLOW, | ||
| resources: [`arn:${Aws.PARTITION}:ec2:${this.region}:${this.ownerAccountId}:vpc-peering-connection/*`], | ||
| conditions: { | ||
| StringEquals: { | ||
| 'ec2:AccepterVpc': `arn:${Aws.PARTITION}:ec2:${this.region}:${this.ownerAccountId}:vpc/${this.vpcId}`, | ||
| }, | ||
| }, | ||
| })); |
There was a problem hiding this comment.
I did not see grant methods exist in the VPC interface, I may be wrong. I believe we need to have some grant methods, and refactor this function later to use the grant methods. I will leave this to @shikha372 to decide what is correct here.
There was a problem hiding this comment.
there is no method currently in VPC, but I agree we can model these permissions under grant method with something like grantPeeringConnection(grantee: iam.IGrantable) and account id as principal, i'll add it in.
Co-authored-by: Shikha Aggarwal <[email protected]>
…/1kaileychen/aws-cdk into vpc_peering_connection_construct
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
Issue # (if applicable)
Contributes to closing RFC#507
Tracking: #30762
Reason for this change
This PR implements a new L2 construct to setup VPC Peering Connection.
Description of changes
validateVpcCidrOverlapto ensure IPv4 CIDR blocks don't overlap for subnets in the VPCsDescription of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license