Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): update bit.ly link to be directly to github #3782

Merged
merged 3 commits into from
Aug 26, 2019

Conversation

alsmola
Copy link
Contributor

@alsmola alsmola commented Aug 25, 2019

The http://bit.ly link seems suspicious. At least make it https, or better yet link directly to the issue.

Update http://bit.ly/cdk-2EhF7Np => #1299


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The http://bit.ly link seems suspicious. At least make it `https`, or better yet link directly to the issue.
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

eladb
eladb previously approved these changes Aug 26, 2019
@eladb eladb changed the title Update bit.ly link to be directly to Github chore(cli): update bit.ly link to be directly to Github Aug 26, 2019
@eladb eladb changed the title chore(cli): update bit.ly link to be directly to Github fix(cli): update bit.ly link to be directly to Github Aug 26, 2019
@eladb eladb changed the title fix(cli): update bit.ly link to be directly to Github fix(cli): update bit.ly link to be directly to github Aug 26, 2019
@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot dismissed eladb’s stale review August 26, 2019 12:11

Pull request has been modified.

@shivlaks
Copy link
Contributor

I agree, it's more transparent and clean to get this link updated.
@alsmola Thanks for your contribution!

@shivlaks shivlaks merged commit 042fb53 into aws:master Aug 26, 2019
@rhboyd
Copy link
Contributor

rhboyd commented Sep 9, 2019

I think this is making the CLI Integration test fail. The change was made in the test but doesn't seem to be in CDK

formatter.warning(`(NOTE: There may be security-related changes not in this list. See http://bit.ly/cdk-2EhF7Np)`);

@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 23, 2019

Yep, well spotted. Fixing it now.

rix0rrr added a commit that referenced this pull request Sep 23, 2019
Fix breakage introduced by #3782, which changed the wrong string.

Update other expectation to match change introduced in #3772.
mergify bot pushed a commit that referenced this pull request Sep 24, 2019
* chore: fix CLI integration tests

Fix breakage introduced by #3782, which changed the wrong string.

Update other expectation to match change introduced in #3772.

* Use substitutions in error message

* Rewrite how CLI tests are being run

* Extract environment setup from tests

* Need to not ignore integ test Javascript files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants