Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wafv2): add L2 IPSet #6230

Closed
wants to merge 13 commits into from
Closed

feat(wafv2): add L2 IPSet #6230

wants to merge 13 commits into from

Conversation

wulfmann
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@wulfmann wulfmann changed the title feat(wafv2): add ipset feat(wafv2): add L3 IPSet Feb 11, 2020
@hoegertn
Copy link
Contributor

hoegertn commented Feb 11, 2020 •
edited
Loading

I like it, as I was planning to create L2 for WAFv2 also. (not L3?)

The main problem ist, that the L1s are currently broken due to CFN Spec errors so this should not deploy to a real AWS account, does it?

@wulfmann wulfmann changed the title feat(wafv2): add L3 IPSet feat(wafv2): add L2 IPSet Feb 11, 2020
@wulfmann
Copy link
Contributor Author

@hoegertn Looks like you are correct, this failed to create with an Internal Failure. Is there an issue that I could link that contains that work?

@wulfmann wulfmann mentioned this pull request Feb 11, 2020
Closed
2 tasks
@hoegertn
Copy link
Contributor

@hoegertn Looks like you are correct, this failed to create with an Internal Failure. Is there an issue that I could link that contains that work?

see #6056 for further info

rix0rrr
rix0rrr previously requested changes Feb 12, 2020
View reviewed changes
packages/@aws-cdk/aws-wafv2/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-wafv2/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-wafv2/lib/ipset.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-wafv2/lib/ipset.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-wafv2/lib/ipset.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-wafv2/lib/ipset.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-wafv2/lib/ipset.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-wafv2/lib/ipset.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-wafv2/lib/ipset.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-wafv2/lib/ipset.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed rix0rrr’s stale review February 17, 2020 13:20

Pull request has been modified.

@iliapolo iliapolo assigned iliapolo and unassigned rix0rrr Jun 8, 2020
@iliapolo
Copy link
Contributor

Hi @wulfmann - Can I ask to the status of this PR? Are you still perusing it?

@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jul 10, 2020
@wulfmann
Copy link
Contributor Author

@iliapolo as far is I remember, this is still ready for merge / review. It was blocked by an issue in the underlying CFN spec. It is unclear if this issue is actually resolved or not #6506. I will try and deploy this construct and see if it works or not and get back to you!

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jul 12, 2020
@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 10, 2020
@github-actions
Copy link

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Aug 11, 2020
@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Aug 13, 2020
@iliapolo
Copy link
Contributor

Hi @wulfmann - I see the tests are still failing. Are you still taking a look? Do you need some assistance? Don't hesitate to reach out.

@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 29, 2020
@wulfmann
Copy link
Contributor Author

Sorry for the delay! Will wrap this up tomorrow

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 1, 2020
@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Oct 3, 2020
@github-actions
Copy link

github-actions bot commented Oct 4, 2020

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Oct 4, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cc0857b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Oct 6, 2020
@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Oct 9, 2020
@github-actions
Copy link

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Oct 13, 2020
@github-actions github-actions bot closed this Oct 17, 2020
@iliapolo
Copy link
Contributor

@wulfmann Feel free to re-open if you are available to pick this up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoegertn hoegertn hoegertn left review comments

@rix0rrr rix0rrr rix0rrr left review comments

Assignees

@iliapolo iliapolo

Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wulfmann @hoegertn @iliapolo @aws-cdk-automation @rix0rrr